tree aadab7de7bbb1ddcd564b12ad49ccbe1feda392b
parent c602c41e328a8215d7b0754eb80b9c6f62aaee9a
author ulfjack <ulfjack@google.com> 1552660782 -0700
committer Copybara-Service <copybara-worker@google.com> 1552660889 -0700

Refactor StandaloneTestStrategy

- remove unnecessary throw in finalizeTest, simplify throws clause
  (TestRunnerAction already throws if the last attempt was unsuccessful)
- remove finally block in executeTestAttempt; don't try to recover from
  non-SpawnExecException, they are catastrophic anyway
- bubble up any IOException thrown in executeTestAttempt; the
  TestRunnerAction already has better handling for them
- Move the prepareFileSystem call to the TestRunnerSpawn
- Clean up createDirectoryAndParents calls
- Move touchFile(out) out of the finally block; it can throw
  IOException, which would cause the original exception to be dropped

- Add a prepareFileSystem overload - this is only called from Google's
  implementation of TestStrategy, but allows us increase consistency
  between the implementations

Note that we no longer include test.xml generation in the runtime of the
test process as measured locally (if the SpawnResult does not have wall
time set, which should usually be the case).

This is in preparation for async test execution.

Progress on #6394.

PiperOrigin-RevId: 238639508