tree 19202be4c9a6c75a68732eb13923c43a3391c0ac
parent 8d4afef85014ca5452cd19542934723ac131b07c
author adonovan <adonovan@google.com> 1581538625 -0800
committer Copybara-Service <copybara-worker@google.com> 1581538685 -0800

bazel syntax: tweaks to Module

This change contains a set of embarrassingly small steps towards
disentangling Module and StarlarkThread, and hiding Module.get{,TransitiveBindings}.
(Every larger step has been into a briar patch.)

- delete testVarOrderDeterminism. The property it ensures is unneeded,
  and the way it uses the production code is unnatural.
- remove incorrect comment in Extension constructor.
- work around warning about Collection.equals being unordered.
- replace unreachable code (universe.universe != null) in
  StarlarkThread.Builder.build by an assertion, and move it into Module.

PiperOrigin-RevId: 294725154