commit e83775d03729f0b0602e64066ead2afd63f3ed46
author ulfjack <ulfjack@google.com> Tue May 14 08:58:46 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue May 14 09:00:15 2019 -0700
tree 03bfb8f11ff8c373fd9b9999c6a3065e36b8637d
parent d1e1cb7dda9d566a39f92459390b3caea316e990

Remove TargetPatternEvaluator

This interface was only used in tests. Update the tests to use
TargetPatternPreloader instead. Remove now-dead code.

This is a simplification in preparation for significantly improving
query performance.

PiperOrigin-RevId: 248145991

src/main/java/com/google/devtools/build/lib/query2/PostAnalysisQueryEnvironment.java

diff --git a/src/main/java/com/google/devtools/build/lib/query2/PostAnalysisQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/PostAnalysisQueryEnvironment.java
index e6c3dac..db36228 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/PostAnalysisQueryEnvironment.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/PostAnalysisQueryEnvironment.java
@@ -40,7 +40,6 @@
 import com.google.devtools.build.lib.pkgcache.FilteringPolicies;
 import com.google.devtools.build.lib.pkgcache.PackageManager;
 import com.google.devtools.build.lib.pkgcache.PathPackageLocator;
-import com.google.devtools.build.lib.pkgcache.TargetPatternEvaluator;
 import com.google.devtools.build.lib.query2.engine.KeyExtractor;
 import com.google.devtools.build.lib.query2.engine.MinDepthUniquifier;
 import com.google.devtools.build.lib.query2.engine.QueryEnvironment;
@@ -242,9 +241,7 @@
   protected TargetPattern getPattern(String pattern) throws TargetParsingException {
     TargetPatternKey targetPatternKey =
         ((TargetPatternKey)
-            TargetPatternValue.key(
-                    pattern, TargetPatternEvaluator.DEFAULT_FILTERING_POLICY, parserPrefix)
-                .argument());
+            TargetPatternValue.key(pattern, FilteringPolicies.NO_FILTER, parserPrefix).argument());
     return targetPatternKey.getParsedPattern();
   }