tree 0e955ee450bd5539d23a4d3347b1dd2d8ef9da3f
parent 1932d0f460681820d10c6501a3b582e319d3d7a1
author nharmata <nharmata@google.com> 1584555098 -0700
committer Copybara-Service <copybara-worker@google.com> 1584555192 -0700

Have PackageFactory#afterDoneLoadingPackage call PackageValidator.validate before it calls Package.Builder.Helper#onLoadingComplete.

This fixes a hypothetical bug where Package.Builder.Helper#onLoadingComplete implementations if rightfully assuming the Package had successfully been loaded when it fact it hadn't.

While I'm here, now that this hypothetical bug has been fixed, I renamed #onLoadingComplete to #onLoadingCompleteAndSuccessful to emphasize that the assumption mentioned above is a legit one to make.

RELNOTES:
PiperOrigin-RevId: 301627063