commit ef6f4cff9ee3e0c92b61f59ca0585f63ff17e9a4
author shahan <shahan@google.com> Tue Jun 26 11:24:59 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Tue Jun 26 11:27:44 2018 -0700
tree 18edd2f65766e2f61f0fe38d4b44497ced83dd09
parent 89dfee5221180aa49b559f22eb6d5bf6bc14c769

Instead of depending on mutable inputs of upstream CppCompileAction instances,
CppCompileAction.discoverInputsStage2 retrieves values of discovered modules
from ActionExecutionValue.

This addresses a possible a correctness issue.

PiperOrigin-RevId: 202162180

src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java
index 5b1305c..8ae2219 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/FilesystemValueCheckerTest.java
@@ -750,6 +750,7 @@
         ImmutableMap.<Artifact, TreeArtifactValue>of(),
         ImmutableMap.<Artifact, FileArtifactValue>of(),
         /*outputSymlinks=*/ null,
+        /*discoveredModules=*/ null,
         /*notifyOnActionCacheHitAction=*/ false);
   }
 
@@ -762,6 +763,7 @@
         ImmutableMap.of(emptyDir, emptyValue),
         ImmutableMap.<Artifact, FileArtifactValue>of(),
         /*outputSymlinks=*/ null,
+        /*discoveredModules=*/ null,
         /*notifyOnActionCacheHitAction=*/ false);
   }
 
@@ -796,6 +798,7 @@
         treeArtifactData,
         ImmutableMap.<Artifact, FileArtifactValue>of(),
         /*outputSymlinks=*/ null,
+        /*discoveredModules=*/ null,
         /*notifyOnActionCacheHitAction=*/ false);
   }