tree 730154d6a3fae633089864ee0bb03992dd1f6650
parent 7812bdce946578e8630af433d78ac2a0e8b8cb2f
author Andreas Herrmann <andreash87@gmx.ch> 1647875091 -0700
committer Copybara-Service <copybara-worker@google.com> 1647875178 -0700

osx_cc_wrapper: Only expand existing response files

Closes #13044
Applies the changes suggested in https://github.com/bazelbuild/bazel/pull/13044#issuecomment-783539568

Not all arguments starting with `@` represent response files, e.g. `-install_name @rpath/...` or `-Xlinker -rpath -Xlinker @loader_path/...` do not refer to response files and attempting to read them as such will fail the build.

Users don't always have control over these arguments, meaning transforming them to `-Wl,-install_name,@rpath/...` or `-Wl,-rpath,@loader_path/...` is not always an option. E.g. as described in https://github.com/bazelbuild/bazel/pull/13044#issuecomment-779380394 where these flags are emitted by the Haskell compiler GHC (see https://github.com/bazelbuild/bazel/pull/13044#issuecomment-782228172 for their reasoning).

With this change `osx_cc_wrapper` will only interpret arguments starting with `@` as response files if the corresponding file exists and is readable. This is analogous to the behavior defined in `wrapped_clang.cc`. See https://github.com/bazelbuild/bazel/pull/13044#issuecomment-783539568 for discussion.

Closes #13148.

PiperOrigin-RevId: 436207868