tree 4b415fa866d3530c3fc350a6cf2a5e06dff1293b
parent 6ba54ac0cde124d4e009f0fe6788e8a1e884fec9
author Fabian Meumertzheim <fabian@meumertzhe.im> 1681749376 +0200
committer GitHub <noreply@github.com> 1681749376 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJkPXWACRBK7hj4Ov3rIwAAG5gIAAL5MKuiVOfzDfkX5W0Zp/fE
 DJ/oIymMhs5hDK+6fnGzl/8lQAng6jIvTq3hsmX3DpBh5BohGrIUwslncHYrqFXb
 1SiVK/hZHRw2uKK3RpEM5aC7ldNnh8kllL3qWQhTkDQ09ETgHuwYo+6nxTJ0KbRZ
 GnvzfL8DxuyXxBkyL0yEN+Iojn37Ikq/+JIhsft8sPwz0rrajgcRGOdA+gG5oPHM
 5llCLMfNEK7lOn85dNZszTBNmhgOOT3HiR6E9I8FHZeJnfn5pj6Lv9pIKvhCEkUD
 ZJ7e7sclffFXDkkV/6p/Ov6GZvKJ24QobsF1Rb6l2m+ZPTU2UFbSh4Co6XoBiI0=
 =0vl6
 -----END PGP SIGNATURE-----
 

Use ctime in file digest cache key (#18115)

File digests are now additionally keyed by ctime for supported file system implementations. Since Bazel has a non-zero default for `--cache_computed_file_digests`, this may be required for correctness in cases where different files have identical mtime and inode number. For example, this can happen on Linux when files are extracted from a tar file with fixed mtime and are then replaced with `mv`, which preserves inodes.

Since Java (N)IO doesn't have support for reading file ctimes on Windows, a new method backed by a native implementation is added to `WindowsFileOperation`. Adding a call to this function to `stat` uncovered previously silent bugs where Unix-style `PathFragment`s were created on Windows:

1. Bzlmod's `createLocalRepoSpec` did not correctly extract the path from a registry's `file://` URI on Windows.
2. `--package_path` isn't usable with absolute paths on Windows as it splits on `:`. Since the flag is deprecated, this commit fixes the tests rather than the implementation.

Fixes #14723

Closes #18003.

PiperOrigin-RevId: 524297459
Change-Id: I96bfc0210e2f71bf8603c7b7cc5eb06a04048c85