tree f6feccc43a81cc7daa54d2a1054fe5dcd2854543
parent 906812c9f93d072ddda732919d20306a50ca0261
author keertk <keerthanakumar@google.com> 1681494824 -0700
committer GitHub <noreply@github.com> 1681494824 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJkOZMoCRBK7hj4Ov3rIwAAcjkIAASQYPcoxUbRo20Q7FaMBvj+
 J637oYq6h8BRlb8xihNtssHXJftiYSku3UdjnrOv+5CIau2vFOJrkize94XpQVfj
 XxFC456tEoNdRReVezPmgvN5BVZ8LqLBhpviNbh3zIvxiYhkT+p8EBZMI+Uv7XIR
 zk5aUwrLGSmAZpsIP8Gp0p0xDd4OoX+JF3Qkr97EU+qeuZTwnDK6hLdHlIkYcSVY
 xMMirBiy4KXB2OSRyZABXhEllRQ25BKS2F03Rif0wqfzSCsEq3SF53u9qIW6TkV3
 TFjIvlgpDcH0X1R9zN3M5gpj/TdaY2cHrqQxRxDYkPWwpEIGsV66upjA3uj3PbY=
 =Zxu4
 -----END PGP SIGNATURE-----
 

Use ctime in file digest cache key (#18101)

File digests are now additionally keyed by ctime for supported file system implementations. Since Bazel has a non-zero default for `--cache_computed_file_digests`, this may be required for correctness in cases where different files have identical mtime and inode number. For example, this can happen on Linux when files are extracted from a tar file with fixed mtime and are then replaced with `mv`, which preserves inodes.

Since Java (N)IO doesn't have support for reading file ctimes on Windows, a new method backed by a native implementation is added to `WindowsFileOperation`. Adding a call to this function to `stat` uncovered previously silent bugs where Unix-style `PathFragment`s were created on Windows:

1. Bzlmod's `createLocalRepoSpec` did not correctly extract the path from a registry's `file://` URI on Windows.
2. `--package_path` isn't usable with absolute paths on Windows as it splits on `:`. Since the flag is deprecated, this commit fixes the tests rather than the implementation.

Fixes #14723

Closes #18003.

PiperOrigin-RevId: 524297459
Change-Id: I96bfc0210e2f71bf8603c7b7cc5eb06a04048c85

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>