tree b720aa3bf79db6d14aef856aba52cd18c1ab0062
parent 31b1b46d5bb4eacb3e5e41da684fe90e23d4f672
author Googler <nharmata@google.com> 1684540989 -0700
committer fweikert <fwe@google.com> 1685101210 +0200

Fix non-determinism in the `FailureDetail` produced for a package with multiple label crosses subpackage boundary errors.

While I'm here, also make the code a tiny bit simpler:
* Explicitly create the empty inner `ArrayList` on each loop iteration. There's no need to use `#computeIfAbsent`; we know no other loop iteration will be processing the same `Target`.
* Use a `List<Pair<Target, List<PackageLookupValue.Key>>>` instead of a `Map<Target, List<PackageLookupValue.Key>>` since we don't need lookup semantics.

PiperOrigin-RevId: 533585562
Change-Id: Iaa3c3d9302a0eef533b55d1f17c33de3ec23666b