tree 45c8e64b99346b600c4a0cd46cc731727b1ebf2b
parent ca728739071c78c67b5d251c7be4b9ba7c17b225
author Googler <lberki@google.com> 1706619873 -0800
committer fweikert <fwe@google.com> 1707503792 +0100

Only cache runfiles mappings of tests if they have more than one shard or run per test.

This is an attempt to fix Bazel excessively OOMing at Google. This change was behavior was caused by https://github.com/bazelbuild/bazel/commit/08df6f1ebeaccb43d3aac1058f8d9e28e11acd2b where I believed that the soft reference makes the caching a no-op wrt. memory use.

This does not quite reinstate the same behavior as before https://github.com/bazelbuild/bazel/commit/08df6f1ebeaccb43d3aac1058f8d9e28e11acd2b: firstly, it doesn't take --test_sharding_strategy into account (it could, but I would have had to make TestShardingStrategy public instead of package-internal) and it doesn't garbage collect the soft reference after the all actions of a given test target finish running. It's still an improvement, though, and profiling shows that it has a good chance of fixing the problem.

RELNOTES: None.
PiperOrigin-RevId: 602689571
Change-Id: Ib68c1b88bf47898ae8a59866447d7790bb6eceee