tree 0c6be4afb437e43eb5ead681c23f0ef27da76403
parent 377860379c315957e7fe4e11f82c31eda338a060
author Fabian Meumertzheim <fabian@meumertzhe.im> 1756827041 +0200
committer GitHub <noreply@github.com> 1756827041 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJotw2yCRC1aQ7uu5UhlAAAx6IQADUkdHlnHdGFmTaDQ3fVqlxt
 rDUnB7HX+xurlrLYiDNB5FAdIcu0eTnf7Z5QY8F9gqJIWeb8E+O8GoNNda3TiP+V
 0GBV8Sm0sem5FnusBV6CCcJnIJ+zowqJuW90IBzzgqAbhGbBJ9awYYT3BuDLgi80
 ueNyfuVCDuZQEqe/D8LumEAc3/3x6tce9Rwc/H3RCs8uBclM4kY/eZ+b6fdlMvxX
 m+TzrXWnzTSpE/lGs4lx8/Oi74Nonm7tRaf9Dw4zPYwfgHVDAxRJrRQu9+7NyuUc
 u3wDXgOBVn96wVjNyRXVDtXHRX4AJevEFGXu6qCTgTfkN+1klD3CvNOhKr6s2ibF
 gex+/X7DCaZZDNotGI5waWkkdqfGmR19/dmZNqd1JU7lFYnfxrLVlyTfVKr4wRaT
 QQaDY3YNY0INtApnFcRLairDxqShcOWv98piZ5Cd/uIUgFk077NFcVyvsj7T2XOl
 41qc2fvMBrnLnCHS2UwBUNfvOoFB3i/TJIlJ9rVoEFwO8lpLM/tQY8Fpujfv4o7V
 tBvMYvGg2xBPLO2zwxIhx935EBU+r5uTMGavzpkpckXYNAQeYJdETug3vm9+dJA0
 ilB2dcQ7wVMSqbj8KWKCVVBQFW0mCT5Irxy/cQtj7ASdNIHNTu7yoB2blypVg1Ub
 ZTF0L+stF5NQFlMymODQ
 =QmXB
 -----END PGP SIGNATURE-----
 

[8.4.0] Fix runfiles directory staleness issues caused by symlinking the output manifest (#26868)

`SymlinkTreeAction` is only executed for its side effect of updating the
runfiles tree, but its up-to-dateness is tracked solely by the digest of
its output, the manifest under the runfiles directory. If this manifest
is a symlink to the input manifest and a previous build modified the
runfiles directory while not updating the action cache entry for
`SymlinkTreeAction`, this would cause Bazel to consider the action
up-to-date even though the runfiles directory is stale.

The fix consists of two parts:
* Always copy the manifest instead of symlinking it, matching the
behavior of the former `--noexperimental_inprocess_symlink_creation`
flag. This fixes staleness issues when only using versions of Bazel with
this fix.
* Detect stale state left behind by older versions of Bazel by skipping
action cache hits if the output manifest is a symlink. Since this
situation is no longer created by fixed versions of Bazel, we could
consider removing this logic in the future.

Fixes #26818

Closes #26837.

PiperOrigin-RevId: 801798862
Change-Id: I02c6d1b353981249a98df224efc4f46c5e4866d7

(cherry picked from commit 585e16c701a6eef9a0b96cce31cae56893f04278)

Also includes:
* a3eb3516b26ddaa2aa81d15a3cbfb6876a07d359

Fixes #26824

---------

Co-authored-by: Googler <tjgq@google.com>