tree 28c9207e495a253dabecb7134fcb544d8b24d806
parent c2b610a28bee0a80395574f671af8730ce2ffb1b
author Jordan <jordan.mele@outlook.com.au> 1738673322 +1100
committer GitHub <noreply@github.com> 1738673322 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJnogyqCRC1aQ7uu5UhlAAAduUQAHFvSchiMUwRDC0SH9qeuQZ2
 dLk3UWM2Q/504Smylrn/13MZNTiz4BpYbAplBxt38hBuxh8lHGGXIxzLsCZ5Fo32
 99RPhozb9ackP50bUDqRFsRYdndht91c+UWFLPsdnbNEqnDYs5ZeV2oFHjokqNMy
 HHjdOvkwHgQXPGkeX6skO6Ttp0Q7/ofT6JHdQQ3ubEERRwKxva7yhRNnrLbjyj4N
 IcfBvoNd0wuZ1rJSBtoBZydU3em3bSqGFjLct51Krb6bK7QHdqpXGgva2NpyYe7t
 TYh+kksUiJrT4VukKxCU0F/SnCw9xIjgEt08CBzhqWHaPxlN66ry2fAiKA7tFpZu
 GcfXgRqz61Ggo5WFAhN0UZJguUxo7oh9qyPDgKSBD6tJwzCoyxwZtOLdwGsE5wvm
 4ABmyEFqaDhLFex8KMIZp6ZYzVHya69oQofAcqH3dX4gd43/7GH08hhD0pmfrGjm
 zIfYZdkPhtw+g4OP+OSnUeTWNx3ieKtlIzPKJGdq8WI2LYdslU273npC6yCjmHVB
 GO92sW8/mXqZKNKyAmBBnZtHMR4TOBZUbCKnbRMQ9z59wIZLuqr5WkVCFgpmoTgZ
 MiAsOGdp0zBlUnwLoVCehP3iKYFQhZc9fg7yd7Dktm7HNtEkxBfEnxVXvNy9kiRX
 wPp9tDcgZCapDN4dZdCW
 =8QVD
 -----END PGP SIGNATURE-----
 

Upload undeclared outputs of failed/flaky/timed out tests (#2169)

Test failures can require information present in undeclared outputs to
diagnose, which if not uploaded means needing to first reproduce the
failure locally.

e.g.
https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/25623#0194aa2c-7bd9-466b-bd15-d7eec8ef58dc
(failure in `test.log` references a file in `test.outputs`) from
https://github.com/bazelbuild/bazel/pull/25050

This PR adds uploading of `test.outputs/*` files for tests that
fail/flake/timeout.

It also;
* Simplifies `local_exec_root.as_ref().map(|p| p.as_path()),` to
`local_exec_root.as_deref(),` (clippy suggestion)
* Lifts the upload decision (dubbed `include_output` in this PR) up a
level so it can be used in the new code branch. I'm fairly `test.log` is
a mandatory test output, so this change should not affect performance.