commit 6556ef19cb72af4545a277012dc58ca877a3f804
author Fabian Meumertzheim <fabian@meumertzhe.im> Wed Nov 27 18:07:27 2024 +0100
committer GitHub <noreply@github.com> Wed Nov 27 18:07:27 2024 +0100
tree 7054a80e90e37d30fba29d4f127d3ae3448e613c
parent a086a7a3240d11cc288b310e953cca91b1a3a99e

agent: Fix tests and argument order for upload (#2126)

agent/src/artifact/upload.rs

diff --git a/agent/src/artifact/upload.rs b/agent/src/artifact/upload.rs
index 3afeb10..927ba86 100644
--- a/agent/src/artifact/upload.rs
+++ b/agent/src/artifact/upload.rs
@@ -418,13 +418,14 @@
         content_type: Option<&str>,
     ) -> Result<()> {
         let artifact = artifact.display().to_string();
-        let mut args = vec!["artifact", "upload", artifact.as_str()];
+        let mut args = vec!["artifact", "upload"];
         let ct_arg = content_type
             .map(|ct| "--content_type=".to_owned() + ct)
             .unwrap_or_default();
         if !ct_arg.is_empty() {
             args.push(ct_arg.as_str());
         }
+        args.push(artifact.as_str());
         execute_command(dry, cwd, "buildkite-agent", &args)
     }
 

agent/tests/artifact/upload.rs

diff --git a/agent/tests/artifact/upload.rs b/agent/tests/artifact/upload.rs
index 0739032..8a892c8 100644
--- a/agent/tests/artifact/upload.rs
+++ b/agent/tests/artifact/upload.rs
@@ -19,7 +19,7 @@
     ]);
     cmd.assert()
         .success()
-        .stdout(predicates::ord::eq("buildkite-agent artifact upload src\\test\\shell\\bazel\\resource_compiler_toolchain_test\\test.log --content_type=text/plain;encoding=utf-8\n"));
+        .stdout(predicates::ord::eq("buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 src\\test\\shell\\bazel\\resource_compiler_toolchain_test\\test.log\n"));
 
     Ok(())
 }
@@ -37,7 +37,7 @@
     ]);
     cmd.assert()
         .success()
-        .stdout(predicates::ord::eq("buildkite-agent artifact upload src/test/shell/bazel/starlark_repository_test/shard_4_of_6/test_attempts/attempt_1.log --content_type=text/plain;encoding=utf-8\n"));
+        .stdout(predicates::ord::eq("buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 src/test/shell/bazel/starlark_repository_test/shard_4_of_6/test_attempts/attempt_1.log\n"));
 
     Ok(())
 }
@@ -139,7 +139,7 @@
     ]);
     cmd.assert()
         .success()
-        .stdout(predicates::str::contains("buildkite-agent artifact upload src/test/shell/bazel/starlark_repository_test/shard_4_of_6/test_attempts/attempt_1.log").count(1));
+        .stdout(predicates::str::contains("buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 src/test/shell/bazel/starlark_repository_test/shard_4_of_6/test_attempts/attempt_1.log").count(1));
 
     Ok(())
 }
@@ -178,7 +178,7 @@
 
         cmd.assert()
         .success()
-        .stdout(predicates::str::contains("buildkite-agent artifact upload src/test/shell/bazel/starlark_repository_test/shard_4_of_6/test_attempts/attempt_1.log"));
+        .stdout(predicates::str::contains("buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 src/test/shell/bazel/starlark_repository_test/shard_4_of_6/test_attempts/attempt_1.log"));
         Ok(())
     })
 }