[nullability] Simplify flow conditions produced when comparing against `nullptr`.

When comparing against `nullptr`, instead of adding three implications to the
flow condition, we can leave the flow condition unchanged and simply use the
nullstate of the operand that isn't `nullptr`, potentially with an added
negation.

Comparing against `nullptr` is the overwhelmingly common case, and simpler flow
conditions help in two ways:

- The SAT solver needs to do less work.

- Flow conditions are easier to interpret when debugging.

The tests in test/comparisons.cc already provide coverage for the new case
distinctions introduced here.

PiperOrigin-RevId: 559659135
Change-Id: I37ad7430654646cd31c3bcd4e69e97010496d6e5
1 file changed
tree: fadef90435e0010edffcbc9ba3a0715b84990c57
  1. .bazelci/
  2. bazel/
  3. cc_bindings_from_rs/
  4. common/
  5. docs/
  6. examples/
  7. lifetime_analysis/
  8. lifetime_annotations/
  9. migrator/
  10. nullability/
  11. rs_bindings_from_cc/
  12. support/
  13. .bazelrc
  14. .gitignore
  15. BUILD
  16. Cargo.lock
  17. CODE_OF_CONDUCT
  18. CONTRIBUTING
  19. LICENSE
  20. README.md
  21. WORKSPACE
README.md

Crubit: C++/Rust Bidirectional Interop Tool

Build status

Crubit is an experimental bidirectional bindings generator for C++ and Rust.

Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.

Crubit allows for C++ code and Rust code to call each other without manually wrapping the APIs in an FFI-friendly interop layer. For example, a C++ function like this:

bool IsAbsPath(std::string_view path);

... becomes callable from Rust as if it were defined as:

pub fn IsAbsPath(path: std::string_view) -> bool {...}

Crubit automatically generates ABI-compatible bindings for structs (which can be passed both by value and by reference), functions, and methods, for a large variety of types. (Trivial types, nontrivial types, templated types, etc.)

Building Crubit

$ apt install clang lld bazel
$ git clone git@github.com:google/crubit.git
$ cd crubit
$ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl

Using a prebuilt LLVM tree

$ git clone https://github.com/llvm/llvm-project
$ cd llvm-project
$ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install
$ cmake --build build -j
$ # wait...
$ cmake --install build
$ cd ../crubit
$ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl