commit 1221c2a5739adc74f59c464e537cdfb98fd391f7
author Devin Jeanpierre <jeanpierreda@google.com> Thu May 05 22:36:22 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Thu May 05 22:36:50 2022 -0700
tree 8c33027eeffad9637f7ff7f6017056bc57d04e58
parent f596aec90bf0e75928a723ac80feb4210009170d

Compute the space occupied by bases, vptr, etc. based on offset of first field.

This amounts to giving up: rather than enumerating each source of data, we just check the offset of the first field (or end of the array). I did it this way because, best as I can tell, ASTRecordLayout does not export information about vtable pointers except whether one exists or not -- so, for example, it doesn't say how many there are. It's simpler and unifying for several cases to simply write down an opaque thunk. This also unifies the logic with the empty struct / sizeof one case, though really that might be a bad thing, as it prevents us from making the field public.

We do still need to e.g. check that any base classes exist at all, in order to decide whether there must be a private field.

PiperOrigin-RevId: 446904649