| commit | 2ecb27fb5c8e7a1da1112d540d286e3c90221431 | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@google.com> | Thu Jan 12 15:29:51 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 12 15:30:41 2023 -0800 |
| tree | 846b5c51737fcb471639d90b3c44a6cf75e18a7d | |
| parent | e3c3947d82ef73f0ef8a4901eb86ed7daefbb517 [diff] |
Panic if `CcPrerequisites::defs` dependency cycle is detected. In the past I have incorrectly thought that some Rust APIs cannot be translated into C++ bindings, because of a dependency cycle that cannot be broken by a forward declaration. I have recently learned that the example based on the static methods doesn't necessarily need to form a cycle (details in b/260725687#comment3). Therefore at this point there are no known scenarios where `CcPrerequisites::defs` can form a cycle. Based on the above, this CL makes the following changes: * Asserts that `failed_ids` returned from `toposort` are always empty * Removes formatting `failed_ids` into unsupported-item comments in the generated `..._cc_api.h` file. * Trims the rationale for having a custom `toposort.rs` crate instead of reusing one of Cargo crates. PiperOrigin-RevId: 501682999
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl