| commit | 381e2b904073a1c6490f1e1c323eb1b8e5b8595f | [log] [tgz] |
|---|---|---|
| author | Martin Brænne <mboehme@google.com> | Mon Jun 26 01:02:48 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jun 26 01:03:25 2023 -0700 |
| tree | d50e9ed57824c2b9b28859682b7cee1eea037839 | |
| parent | 000d1c66e9564bf24bbbfe746c9d75a1630bb850 [diff] |
[nullability] Fix a crash when calling builtin functions. Despite its name, the result type of `BuiltinFnToFnPtr` cast is a function, not a function pointer. This means that the callee of a `CallExpr` to a builtin function is not a pointer and so does not have nullability information associated with it. We therefore crashed when trying to access this nullability information. We fix this by only checking for nullability if we have an indirect callee. Direct callees are always non-null, and it isn't possible to take the address of a builtin function, so calls to builtin functions are always direct. We also fix the implementation of the `BuiltinFnToFnPtr` cast so that it doesn't prepend an additional `NullabilityKind::NonNull`. The implementation of the `BuiltinFnToFnPtr` cast in the dataflow framework will also need to be changed, as it currently creates a pointer. However, the current fix will prevent the crash even before the dataflow framework is changed because the nullability checker will now never attempt to query the value associated with the callee to a builtin function. PiperOrigin-RevId: 543360562
Crubit is an experimental bidirectional bindings generator for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
Crubit allows for C++ code and Rust code to call each other without manually wrapping the APIs in an FFI-friendly interop layer. For example, a C++ function like this:
bool IsAbsPath(std::string_view path);
... becomes callable from Rust as if it were defined as:
pub fn IsAbsPath(path: std::string_view) -> bool {...}
Crubit automatically generates ABI-compatible bindings for structs (which can be passed both by value and by reference), functions, and methods, for a large variety of types. (Trivial types, nontrivial types, templated types, etc.)
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl