commit 408ef40425d0c64b1dc3b4ecdfd891e671819059
author Googler <no-reply@google.com> Mon Nov 28 02:59:28 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Nov 28 03:00:00 2022 -0800
tree d882517f0917172ca29c823364ab285bfceedb38
parent dadada40f28f19cd841dbaaa882a5c1633330e0f

Replace `String` with `Rc<str>` in ir::Operator to improve `Clone` performance

PiperOrigin-RevId: 491293385

rs_bindings_from_cc/ir.rs

diff --git a/rs_bindings_from_cc/ir.rs b/rs_bindings_from_cc/ir.rs
index 51bf7af..142ea9b 100644
--- a/rs_bindings_from_cc/ir.rs
+++ b/rs_bindings_from_cc/ir.rs
@@ -189,7 +189,7 @@
 
 #[derive(PartialEq, Eq, Hash, Clone, Deserialize)]
 pub struct Operator {
-    pub name: String,
+    pub name: Rc<str>,
 }
 
 impl Operator {

rs_bindings_from_cc/src_code_gen.rs

diff --git a/rs_bindings_from_cc/src_code_gen.rs b/rs_bindings_from_cc/src_code_gen.rs
index 544dde2..b06999f 100644
--- a/rs_bindings_from_cc/src_code_gen.rs
+++ b/rs_bindings_from_cc/src_code_gen.rs
@@ -715,7 +715,7 @@
         {
             return Ok(None);
         }
-        UnqualifiedIdentifier::Operator(op) if op.name == "==" => {
+        UnqualifiedIdentifier::Operator(op) if op.name.as_ref() == "==" => {
             assert_eq!(
                 param_types.len(),
                 2,
@@ -760,10 +760,10 @@
                 /* force_const_reference_params= */ true,
             )?;
         }
-        UnqualifiedIdentifier::Operator(op) if op.name == "<=>" => {
+        UnqualifiedIdentifier::Operator(op) if op.name.as_ref() == "<=>" => {
             bail!("Three-way comparison operator not yet supported (b/219827738)");
         }
-        UnqualifiedIdentifier::Operator(op) if op.name == "<" => {
+        UnqualifiedIdentifier::Operator(op) if op.name.as_ref() == "<" => {
             assert_eq!(
                 param_types.len(),
                 2,
@@ -815,7 +815,7 @@
             // implemented for this Record type.
             match get_binding(
                 db,
-                UnqualifiedIdentifier::Operator(Operator { name: "==".to_string() }),
+                UnqualifiedIdentifier::Operator(Operator { name: Rc::from("==") }),
                 param_types,
             ) {
                 Some((_, ImplKind::Trait { trait_name: TraitName::PartialEq { .. }, .. })) => {
@@ -832,7 +832,7 @@
                 _ => bail!("operator< where operator== is missing."),
             }
         }
-        UnqualifiedIdentifier::Operator(op) if op.name == "=" => {
+        UnqualifiedIdentifier::Operator(op) if op.name.as_ref() == "=" => {
             assert_eq!(
                 param_types.len(),
                 2,
@@ -866,7 +866,7 @@
         }
         UnqualifiedIdentifier::Operator(op) => match op_meta
             .by_cc_name_and_params
-            .get(&(op.name.as_str(), param_types.len()))
+            .get(&(&op.name, param_types.len()))
         {
             Some(OperatorMetadataEntry {
                 trait_name,
@@ -3175,7 +3175,7 @@
             }
             // This doesn't affect void in function return values, as those are special-cased to be
             // omitted.
-            RsTypeKind::Unit => quote!{::std::os::raw::c_void},
+            RsTypeKind::Unit => quote! {::std::os::raw::c_void},
             RsTypeKind::Other { name, type_args } => {
                 let ident = make_rs_ident(name);
                 let generic_params =
@@ -6296,7 +6296,10 @@
             })
             .find(|f| {
                 matches!(&f.name, UnqualifiedIdentifier::Constructor)
-                    && f.params.get(1).map(|p| p.identifier.identifier.as_ref() == "i").unwrap_or_default()
+                    && f.params
+                        .get(1)
+                        .map(|p| p.identifier.identifier.as_ref() == "i")
+                        .unwrap_or_default()
             })
             .unwrap();
         {