Google Git
Sign in
bazel / crubit / 5087e1f05a59bffa71873826d89d82a04dda80c0
commit5087e1f05a59bffa71873826d89d82a04dda80c0[log] [tgz]
authorLukasz Anforowicz <lukasza@google.com>Mon Apr 03 08:41:29 2023 -0700
committerCopybara-Service <copybara-worker@google.com>Mon Apr 03 08:42:15 2023 -0700
tree3b17f3d898b8f6dfa686564a1f123cfa6dff392d
parent411fa7e767cd315bc289de2eaf1a9ca2174cd672 [diff]
Remove remaining TODOs related to `'static` lifetime of `fn` pointers.

After the recent work on b/275628345 the `lifetime_annotations` layer
guarantees that function pointers and references either 1) have no
associated lifetime (without lifetime elision) or 2) have an inferred
`'static` lifetime.  This CL tweaks the associated TODOs and assertions
in `importer.cc` and `src_code_gen.rs` to reconcile that with that work.

(Note that the text of the TODOs has incorrectly assumed that there
will be always no lifetime associated with function pointers/references.
The CL changes the assertions and comments to agree with the current
behavior in this area.)

The CL also removes the `test_func_ptr_with_non_static_lifetime` test.
The test is no longer applicable (since we reject function pointers
with non-`'static` lifetime in the `lifetime_annotations` layer (*).
Also note that the test used a no-op assertion: an `assert_rs_matches`
with an empty `pattern` (removal of the test is necessary to move
forward with unknown commit).

(*) I don't understand why the unit test in `src_code_gen.rs` doesn't
report any compile errors when `$a` lifetime is used in the unit test.
This might be interesting to investigate, but doesn't change the
need to remove the obsolete test.

PiperOrigin-RevId: 521468722
2 files changed
tree: 3b17f3d898b8f6dfa686564a1f123cfa6dff392d
  1. .bazelci/
  2. bazel/
  3. cc_bindings_from_rs/
  4. common/
  5. docs/
  6. lifetime_analysis/
  7. lifetime_annotations/
  8. migrator/
  9. nullability_verification/
  10. rs_bindings_from_cc/
  11. support/
  12. .bazelrc
  13. .gitignore
  14. BUILD
  15. Cargo.Bazel.lock
  16. CODE_OF_CONDUCT
  17. CONTRIBUTING
  18. LICENSE
  19. README.md
  20. WORKSPACE
README.md

Crubit: C++/Rust Bidirectional Interop Tool

Build status

Extremely experimental interop tooling for C++ and Rust.

Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.

Building Crubit

$ apt install clang lld bazel
$ git clone git@github.com:google/crubit.git
$ cd crubit
$ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl

Using a prebuilt LLVM tree

$ git clone https://github.com/llvm/llvm-project
$ cd llvm-project
$ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install
$ cmake --build build -j
$ # wait...
$ cmake --install build
$ cd ../crubit
$ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl