Google Git
Sign in
bazel / crubit / 1bcd7261c460154bd1df1e04c299681331401707
commit1bcd7261c460154bd1df1e04c299681331401707[log] [tgz]
authorDevin Jeanpierre <jeanpierreda@google.com>Tue Oct 04 20:07:59 2022 -0700
committerCopybara-Service <copybara-worker@google.com>Tue Oct 04 20:08:32 2022 -0700
tree090623e43cbcb3a1f6a35ab54269dc7e073671f1
parente7874b5c7f98d1e0354ff7a99b16e4cb149d5f6d [diff]
Move graph traversal updates so that they are compatible with records being imported during record import.

This is pretty subtle, so I've split it out to a separate change, even though it doesn't happen right now, or at least not in any of our tests.

In particular, consider the following failure modes:

1. a record is imported during its own import. This causes the cache to be set to `nullopt` (since it's marked as already imported), and the insertion to fail. So we actually need to overwrite (or be even cleverer still).
2. a record is imported by its fields during its own import. Because in the old version of the code, it wasn't cached before it had the fields imported, this causes an infinite loop (and eventual stack overflow).

There may have been another failure mode I am forgetting.

In order to help debug the first kind of failure, where we foul the cache with `nullopt`, I've also changed it from `nullopt` to an unsupported item. This will never show up at all when things are working correctly, and is just to aid debugging.

PiperOrigin-RevId: 478945495
4 files changed
tree: 090623e43cbcb3a1f6a35ab54269dc7e073671f1
  1. .bazelci/
  2. bazel/
  3. cc_bindings_from_rs/
  4. cc_import/
  5. cc_template/
  6. common/
  7. docs/
  8. lifetime_analysis/
  9. lifetime_annotations/
  10. migrator/
  11. nullability_verification/
  12. rs_bindings_from_cc/
  13. .bazelrc
  14. .gitignore
  15. BUILD
  16. Cargo.Bazel.lock
  17. CODE_OF_CONDUCT
  18. CONTRIBUTING
  19. LICENSE
  20. README.md
  21. WORKSPACE
README.md

Crubit: C++/Rust Bidirectional Interop Tool

Build status

Extremely experimental interop tooling for C++ and Rust.

Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.

Building Crubit

$ apt install clang lld bazel
$ git clone git@github.com:google/crubit.git
$ cd crubit
$ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl

Using a prebuilt LLVM tree

$ git clone https://github.com/llvm/llvm-project
$ cd llvm-project
$ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install
$ cmake --build build -j
$ # wait...
$ cmake --install build
$ cd ../crubit
$ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl