commit 61d4e3630fb358f8c72bc52ec0c773927972dbf3
author Martin Brænne <mboehme@google.com> Thu Apr 27 01:07:59 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 27 01:08:29 2023 -0700
tree bd5d75d578adcbb65b648dc10109fec94de80624
parent 60ed6c80f6aef0bfa021dbe5e541c7a9f5c5b7b7

[nullability] Fix a null-pointer crash (ironically) on a null `TypeSourceInfo`.

This change adds a test that, without the fix, reproduces the crash.

PiperOrigin-RevId: 527502867

nullability_verification/pointer_nullability_analysis.cc

diff --git a/nullability_verification/pointer_nullability_analysis.cc b/nullability_verification/pointer_nullability_analysis.cc
index 8ec1323..e4a4729 100644
--- a/nullability_verification/pointer_nullability_analysis.cc
+++ b/nullability_verification/pointer_nullability_analysis.cc
@@ -174,10 +174,10 @@
                 dyn_cast<DeclRefExpr>(CE->getCallee()->IgnoreImpCasts());
             DRE != nullptr && ST->getReplacedParameter()->getDepth() == 0 &&
             DRE->hasExplicitTemplateArgs()) {
-          return getNullabilityAnnotationsFromType(
-              DRE->template_arguments()[ST->getIndex()]
-                  .getTypeSourceInfo()
-                  ->getType());
+          TypeSourceInfo* TSI =
+              DRE->template_arguments()[ST->getIndex()].getTypeSourceInfo();
+          if (TSI == nullptr) return std::nullopt;
+          return getNullabilityAnnotationsFromType(TSI->getType());
         }
         return std::nullopt;
       });