| commit | 25f9f5add602c3d828afaf167a4354119d3f13f1 | [log] [tgz] |
|---|---|---|
| author | Devin Jeanpierre <jeanpierreda@google.com> | Tue Mar 14 20:39:10 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Mar 14 20:39:43 2023 -0700 |
| tree | 9ad9842f8189bb6ab21e59b92fb66f4751d00558 | |
| parent | dff652864b17de8aa5a0ea2ec6a2cbcce8f6dfc6 [diff] |
Include C++ thunk impls for functions and records inside their `GeneratedItem`. (There are some unimportant formatting changes that result from this -- since they're added from a different place, the source order can change, and since they're added one-by-ne, there's extra newlines. That should be all.) This wasn't possible before the refactoring https://github.com/google/crubit/commit/c1647512afacf7c3440f7fa3ba9debbf8cf70ffb. Now that it's possible, doing this allows us to kill the parallel checks: we don't want to generate thunks if we don't generate the public API, so we used to do the same checks in parallel (effectively asking, in the thunk writing code, "will I generate a public API?" -- this was messy. And in particular, this broke when I added a new reason that API generation can fail (feature flags). By including the thunks inside the actual API GeneratedItem, they're paired together completely, and will never go out of sync ever again. This also resolves the messy todo around overloaded functions: now, thunks get suppressed for overloaded functions for the same reason as the API definition does, and we don't need to worry anymore about dependency cycles. PiperOrigin-RevId: 516708846
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl