| commit | 6af160e07125c18378fa6d8d85abefe79700a25c | [log] [tgz] |
|---|---|---|
| author | Devin Jeanpierre <jeanpierreda@google.com> | Wed Sep 21 05:30:34 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Sep 21 05:31:10 2022 -0700 |
| tree | 423423f3738737b370f5b3a2f09cf6f4df6cdfa2 | |
| parent | 253ceb46ca8aae59cbce53a602a4129b6fea4636 [diff] |
Lift records behind typedefs into first-class (cached) items. The previous algorithm was not sound: it would, as part of graph traversal, mark that a record would be successfully imported when it first encountered it, under the assumption that the import would be cached. However, typedefs specifically bypassed this caching. And so you could, if you tried to import a typedef _before_ the struct it imported, accidentally mark the struct as imported, without actually importing it, thus preventing future import and causing dangling DeclIDs. This change removes that, and should unblock future work to import more typedef declarations. After this CL, all records which are successfully imported in some way have an Item, returned by the Record importer -- *not* the typedef importer. The typedef importer, if it sees sees anonymous structs, skips them. Special handling of typedefs is, as a consequence, partially bled into the record importer. I've left a TODO in the place where this needs to be refactored in the future. (This took me WAY too long to debug and write! Spooky action at a distance, yo.) PiperOrigin-RevId: 475802057
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl