commit 7e1aa2a88cd422b6ae70a50c74aeaaaa8e6587ab
author Jorge Gorbe Moya <jgorbe@google.com> Tue Mar 01 04:05:40 2022 +0000
committer Marcel Hlopko <hlopko@google.com> Fri Mar 25 22:22:09 2022 +0000
tree ac235b540415865d754d46e76a7ce965d85381a5
parent 8a8e82e4aa137a02ecd59a14e0fe42de3ecb2d8a

Fix stack-use-after-scope.

Since https://reviews.llvm.org/D120334, passing a temporary LangOptions
object to Lexer results in stack-use-after-scope. I missed this when I
submitted the integrate: TAP failed to run some tests (which is the part I
missed), and then I had to add NO_SQ to get around some other problem (which
was fine). Fixing it forward.

PiperOrigin-RevId: 431587591

lifetime_annotations/lifetime_annotations.cc

diff --git a/lifetime_annotations/lifetime_annotations.cc b/lifetime_annotations/lifetime_annotations.cc
index 45188d4..4f73411 100644
--- a/lifetime_annotations/lifetime_annotations.cc
+++ b/lifetime_annotations/lifetime_annotations.cc
@@ -135,7 +135,8 @@
     return error(toString(std::move(err)));
   }
   std::string lifetimes_str = lifetimes.str();
-  clang::Lexer lexer(attr->getLoc(), clang::LangOptions(), lifetimes_str.data(),
+  clang::LangOptions lang_opts;
+  clang::Lexer lexer(attr->getLoc(), lang_opts, lifetimes_str.data(),
                      lifetimes_str.data(),
                      lifetimes_str.data() + lifetimes_str.size());