commit 802fea1d4bfc11feeb1e3e265ff75f980ec6b9de
author Martin Brænne <mboehme@google.com> Tue Aug 01 06:29:55 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Aug 01 06:31:23 2023 -0700
tree 8d8979fb99c7f85dca100a50b8cbe3f2da8a933b
parent 717a1861c47f8f5bc3930732431ca08281e916a3

[nullability] Remove `Strict` suffix when calling `Environment` accessors.

The versions of the functions without the `Strict` now mean the same thing, and
the `Strict` versions are going away.

PiperOrigin-RevId: 552784503
Change-Id: Ib2d6b917707fe3ebb6169c581aac9d370d3704a2

nullability/pointer_nullability_analysis.cc

diff --git a/nullability/pointer_nullability_analysis.cc b/nullability/pointer_nullability_analysis.cc
index aa6b7ce..846b90b 100644
--- a/nullability/pointer_nullability_analysis.cc
+++ b/nullability/pointer_nullability_analysis.cc
@@ -365,7 +365,7 @@
   if (!PointerVal) return;
 
   auto [FromNullable, PointerNull] = getPointerNullState(*PointerVal);
-  State.Env.setValueStrict(*CastExpr, State.Env.makeNot(PointerNull));
+  State.Env.setValue(*CastExpr, State.Env.makeNot(PointerNull));
 }
 
 void transferFlowSensitiveCallExpr(
@@ -379,13 +379,13 @@
     // The function returned a reference. Create a storage location for the
     // expression so that if code creates a pointer from the reference, we will
     // produce a `PointerValue`.
-    Loc = State.Env.getStorageLocationStrict(*CallExpr);
+    Loc = State.Env.getStorageLocation(*CallExpr);
     if (!Loc) {
       // This is subtle: We call `createStorageLocation(QualType)`, not
       // `createStorageLocation(const Expr &)`, so that we create a new
       // storage location every time.
       Loc = &State.Env.createStorageLocation(CallExpr->getType());
-      State.Env.setStorageLocationStrict(*CallExpr, *Loc);
+      State.Env.setStorageLocation(*CallExpr, *Loc);
     }
   }
 
@@ -404,7 +404,7 @@
     else
       // `Loc` is set iff `CallExpr` is a glvalue, so we know here that it must
       // be a prvalue.
-      State.Env.setValueStrict(*CallExpr, *PointerVal);
+      State.Env.setValue(*CallExpr, *PointerVal);
   }
 }
 
@@ -751,7 +751,7 @@
 
   if (Env.getValue(*E) == nullptr)
     // `createValue()` always produces a value for pointer types.
-    Env.setValueStrict(*E, *Env.createValue(E->getType()));
+    Env.setValue(*E, *Env.createValue(E->getType()));
 }
 
 }  // namespace