commit 81b36a845f0cb08c3220ab156f953d165f37a475
author Lukasz Anforowicz <lukasza@google.com> Sat Sep 17 07:16:42 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Sat Sep 17 07:17:18 2022 -0700
tree 26c2a2c27892b1a32b51dc15623a17f59d8095e6
parent 06c929218e4348ec34959efdf18c5110bee25c57

Remove unused `Namespace::enclosing_record_id` field from `ir.rs`.

Before and after this CL, `enclosing_record_id` is a property of
TypeAlias:

1. Declared as a field of `struct TypeAlias` in `ir.h` and `ir.rs`
2. Read in `TypeAlias::ToJson` in `ir.cc` and in 3 places in
   `src_code_gen.rs`.
3. Written to in `importers/typedef_name.cc`

Before this CL, `enclosing_record_id` would also accidentally
be declared as a field of `struct Namespace` in `ir.rs`, even
though 1) it wasn't declared as a field in `ir.h`, and 2) wasn't
read-from or written-to anywhere.

PiperOrigin-RevId: 475014974

rs_bindings_from_cc/ir.rs

diff --git a/rs_bindings_from_cc/ir.rs b/rs_bindings_from_cc/ir.rs
index 99c49c4..f86451d 100644
--- a/rs_bindings_from_cc/ir.rs
+++ b/rs_bindings_from_cc/ir.rs
@@ -521,7 +521,6 @@
     pub owning_target: BazelLabel,
     #[serde(default)]
     pub child_item_ids: Vec<ItemId>,
-    pub enclosing_record_id: Option<ItemId>,
     pub enclosing_namespace_id: Option<ItemId>,
     pub is_inline: bool,
 }

rs_bindings_from_cc/ir_from_cc_test.rs

diff --git a/rs_bindings_from_cc/ir_from_cc_test.rs b/rs_bindings_from_cc/ir_from_cc_test.rs
index b05e88e..a00bac3 100644
--- a/rs_bindings_from_cc/ir_from_cc_test.rs
+++ b/rs_bindings_from_cc/ir_from_cc_test.rs
@@ -2394,7 +2394,6 @@
                 name: "MyNamespace" ...
                 id: ItemId(#ns_id) ...
                 child_item_ids: [ItemId(#child_id)] ...
-                enclosing_record_id: None ...
                 enclosing_namespace_id: None ...
             }),
             IncompleteRecord(IncompleteRecord {