| commit | 42ab93b7b67529e026d2cbe02ea09f1a72153851 | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@google.com> | Wed Aug 31 11:17:59 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Aug 31 11:18:42 2022 -0700 |
| tree | ebde837f4a5f284b5792a8c8d57b0c3e0883cf69 | |
| parent | 8dd517949570576dfdedb115f706b0a1a0fd4f95 [diff] |
Avoid dangling item ids for skipped template specializations. Before this CL, `class_template_instantiations_for_current_target_` was populated before checking `import_status`. This could lead to dangling `top_level_item_ids`. This CL fixes this problem and adds a handful of `.with_context(...)` calls that helped investigate where the dangling item ids were present. Before this CL `rs_bindings_from_cc/test/consume_absl:main` test would trigger a crash/error/panic in `rs_bindings_from_cc`. After this CL, the test merely hits some `redefinition of '__rust_thunk...'` errors in the generated `absl/numeric/int128_rust_api_impl.cc`. PiperOrigin-RevId: 471302280
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl