)]}'
{
  "commit": "8b475a4b28a3dc31b83f23470d95fe60718d26c7",
  "tree": "1c1805eda93915b76694ebec4ffb5917be5b563a",
  "parents": [
    "841386cc4ee97b85dd426921768f5811ca8d2d40"
  ],
  "author": {
    "name": "Lukasz Anforowicz",
    "email": "lukasza@google.com",
    "time": "Tue Nov 29 09:33:02 2022 -0800"
  },
  "committer": {
    "name": "Copybara-Service",
    "email": "copybara-worker@google.com",
    "time": "Tue Nov 29 09:33:32 2022 -0800"
  },
  "message": "Fix handling of `std::cmp::Ordering` and `Option\u003ci8\u003e` in `format_ty...`.\n\nBefore this CL the \"Cross-crate dependencies are not supported yet\n(b/258261328)\" error had no test coverage.  Adding this test coverage is\nthe primary motivation for this CL.  This CL is triggered by the\nrealization that cross-crate test coverage can be provided by testing\ntypes from the `std` crate (earlier I thought that testing these\nscenarios will require modifying `test::run_compiler` to support\ndepending on other crates).\n\nAdding tests for `std::cmp::Ordering` helped flush out an additional\nbug: `format_ty_for_rs` incorrectly assumed that `ty.to_string()`\nreturns a single identifier and panicked when it returned\n\"std::cmp::Ordering\".  Fixing this bug encouraged introduction of\ninitial, minimal support for modules/namespaces and reusing\n`NamespaceQualifier` from `rs_bindings_from_cc`.\n\nThe CL also opportunistucally adds test coverage for _generic_\ntypes from other crates - by testing `Option\u003ci8\u003e`.\n\nPiperOrigin-RevId: 491660080\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "eb9d59e9e2a085239225d5ab09fd6124245fc503",
      "old_mode": 33188,
      "old_path": "cc_bindings_from_rs/bindings.rs",
      "new_id": "dbe6c5414e4fc3f5f86781202020122e6c0fb9b0",
      "new_mode": 33188,
      "new_path": "cc_bindings_from_rs/bindings.rs"
    },
    {
      "type": "modify",
      "old_id": "9fc4a88efa02de0ad6ea31781931745ba15c01b7",
      "old_mode": 33188,
      "old_path": "cc_bindings_from_rs/cc_bindings_from_rs.rs",
      "new_id": "b878a343448b19bcb0eb49f8984d381341a843a1",
      "new_mode": 33188,
      "new_path": "cc_bindings_from_rs/cc_bindings_from_rs.rs"
    }
  ]
}