commit 9f8ab4f84ace552d23ba5fd1be4e2e5540c17d89
author Devin Jeanpierre <jeanpierreda@google.com> Thu Sep 16 10:36:19 2021 +0000
committer Marcel Hlopko <hlopko@google.com> Fri Mar 25 21:51:59 2022 +0000
tree 7c58ef1c4123b637af467596510943f34f1f3283
parent 5c87a72d566b4896891b1a57c73ab59e9ebb578f

Use ASSERT_THAT when the test will encounter UB if the expect fails -- see[]

PiperOrigin-RevId: 397043365

rs_bindings_from_cc/ast_visitor_test.cc

diff --git a/rs_bindings_from_cc/ast_visitor_test.cc b/rs_bindings_from_cc/ast_visitor_test.cc
index d1e35f8..a49ae28 100644
--- a/rs_bindings_from_cc/ast_visitor_test.cc
+++ b/rs_bindings_from_cc/ast_visitor_test.cc
@@ -61,7 +61,7 @@
 TEST(AstVisitorTest, Noop) {
   IR ir = ImportCode({"// nothing interesting there."}, {});
   EXPECT_THAT(ir.Functions(), IsEmpty());
-  EXPECT_THAT(ir.UsedHeaders(), SizeIs(1));
+  ASSERT_THAT(ir.UsedHeaders(), SizeIs(1));
   EXPECT_EQ(ir.UsedHeaders()[0].IncludePath(), "test/testing_header_0.h");
 }
 
@@ -131,7 +131,7 @@
 
 TEST(AstVisitorTest, FuncParams) {
   IR ir = ImportCode({"int Add(int a, int b);"}, {});
-  EXPECT_THAT(ir.Functions(), SizeIs(1));
+  ASSERT_THAT(ir.Functions(), SizeIs(1));
 
   Func func = ir.Functions()[0];
   EXPECT_EQ(func.identifier.Ident(), "Add");
@@ -139,7 +139,7 @@
   EXPECT_EQ(func.return_type.rs_name, "i32");
   EXPECT_THAT(func.return_type.type_params, IsEmpty());
 
-  EXPECT_THAT(func.params, SizeIs(2));
+  ASSERT_THAT(func.params, SizeIs(2));
   EXPECT_EQ(func.params[0].type.rs_name, "i32");
   EXPECT_THAT(func.params[0].type.type_params, IsEmpty());
   EXPECT_EQ(func.params[0].identifier.Ident(), "a");
@@ -173,16 +173,19 @@
   IR ir = ImportCode(
       {"struct SomeStruct { int first_field; int second_field; };"}, {});
   EXPECT_THAT(ir.Functions(), SizeIs(0));
-  EXPECT_THAT(ir.Records(), SizeIs(1));
 
+  ASSERT_THAT(ir.Records(), SizeIs(1));
   Record some_struct = ir.Records()[0];
-  EXPECT_THAT(some_struct.Fields(), SizeIs(2));
+
   EXPECT_EQ(some_struct.Ident().Ident(), "SomeStruct");
+
+  ASSERT_THAT(some_struct.Fields(), SizeIs(2));
   Field first = some_struct.Fields()[0];
+  Field second = some_struct.Fields()[1];
+
   EXPECT_EQ(first.identifier.Ident(), "first_field");
   EXPECT_EQ(first.type.cc_name, "int");
   EXPECT_EQ(first.type.rs_name, "i32");
-  Field second = some_struct.Fields()[1];
   EXPECT_EQ(second.identifier.Ident(), "second_field");
   EXPECT_EQ(second.type.cc_name, "int");
   EXPECT_EQ(second.type.rs_name, "i32");