For classes nested in template classes, include outer tparams in nullability
Given `template <class T> struct X { struct Y {}; };`
Y can depend on T in the same ways that X can.
Therefore the nullability of T is part of Y's nullability too.
For now, there's no observable effect except that the nullability vectors are the right length, padded with Unspecified, but we're building towards nested template support.
- when we walk up the redecl chain there is no sugar.
My other patch will provide this in some cases ("Resugar substituted type params found in class template instantiations"), we need to look up the template args in the instantiation context.
- we don't consume the outer class nullability anywhere. We will be able to do this around substituteNullabilityAnnotationsInClassTemplate, addressing TODOs about nested templates. This will require some restructuring as we don't actually whether the inner class is a template anymore.
PiperOrigin-RevId: 527969535
diff --git a/nullability_verification/pointer_nullability_analysis.cc b/nullability_verification/pointer_nullability_analysis.cc
index b5e878f..9479b84 100644
--- a/nullability_verification/pointer_nullability_analysis.cc
+++ b/nullability_verification/pointer_nullability_analysis.cc
@@ -127,7 +127,8 @@
unsigned ArgIndex = ST->getIndex();
auto TemplateArgs = Specialization->getTemplateArgs().asArray();
- unsigned PointerCount = 0;
+ unsigned PointerCount =
+ countPointersInType(Specialization->getDeclContext());
for (auto TA : TemplateArgs.take_front(ArgIndex)) {
PointerCount += countPointersInType(TA);
}
