| commit | a492826050e839fe690d5f8f609e5f6913621c9f | [log] [tgz] |
|---|---|---|
| author | Devin Jeanpierre <jeanpierreda@google.com> | Fri Mar 03 13:10:08 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Mar 06 07:02:57 2023 -0800 |
| tree | ffc38b38fc3430f3166960b19dd89a23d5ef93e8 | |
| parent | 9e57fb3ed0a863ebb5f88fb37ca99ae975bf71b6 [diff] |
Fix clippy warning about no-op `mem::forget` call.
Clippy warning:
```
warning: calls to `std::mem::forget` with a value that implements `Copy`. Forgetting a copy leaves the original intact
--> third_party/crubit/support/ctor.rs:836:17
|
836 | ::core::mem::forget(drop_guard);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
1322 | emplace! { let _my_struct = ctor!(MyStruct {});}
| ------------------ in this macro invocation
|
note: argument has type `()`
--> third_party/crubit/support/ctor.rs:836:37
|
836 | ::core::mem::forget(drop_guard);
| ^^^^^^^^^^
...
1322 | emplace! { let _my_struct = ctor!(MyStruct {});}
| ------------------ in this macro invocation
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy
= note: this warning originates in the macro `ctor` (in Nightly builds, run with -Z macro-backtrace for more info)
https://rust-lang.github.io/rust-clippy/master/index.html#forget_copy
```
The `drop_guard` is used in a macro to accumulate non-`Copy` things, but it was initialized, before this CL, to `()`. Initializing it to a non-`Copy` type silences the warning.
PiperOrigin-RevId: 513904055
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl