| commit | ab563aff594eb82e75213936c6b5346bfccadda5 | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@google.com> | Thu Dec 15 08:09:50 2022 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Dec 15 08:10:29 2022 -0800 |
| tree | bad38dc7e445c44a2dfcb42eed994c429b3a651e | |
| parent | f811131c707504cf2fb1489b80a027211a04fff5 [diff] |
Avoid `let def_id.clone()` to translate `&LocalDefId` into `LocalDefId`.
Before this CL, extracting toposort dependencies looked like this:
```
let deps = bindings.iter().flat_map(|(def_id, snippet)| {
let def_id = def_id.clone();
snippet.cc.prereqs.defs.iter().copied().map(move |predecessor| {
toposort::Dependency { predecessor, successor: def_id }
})
});
```
Above the `let def_id = def_id.clone` changes the type of `def_id`
from `&LocalDefId` to `LocalDefId`, but in a rather roundabout way.
After this CL, we get `LocalDefId` by value in a more direct way
(note the extra `&` before the lambda's parameter):
```
let deps = bindings.iter().flat_map(|(&successor, snippet)| {
snippet.cc.prereqs.defs.iter().copied().map(move |predecessor| {
toposort::Dependency { predecessor, successor }
})
});
```
(The CL also makes some other minor changes, including making the code
layout more compact while still keeping `rustfmt` happy.)
PiperOrigin-RevId: 495595924
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl