| commit | b88f19f2e6e0724b7965968550c9a4f756a49a23 | [log] [tgz] |
|---|---|---|
| author | Dani Ferreira Franco Moura <danimoura@google.com> | Thu Jan 26 04:47:09 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 26 04:47:52 2023 -0800 |
| tree | bbb9d702b88d08942302d30af29b425933451fa2 | |
| parent | 92d72bdbdd18583398e4db806c75aa9064b40d55 [diff] |
Add fail-safe to prevent crashes on nullability verification In PointerNullabilityAnalysis::diagnoseReturn, we assert that the return type of the input expression is a pointer, because this action is run on ReturnStmts of pointer type. However, a function could have a ReturnStmt of pointer type and not have a pointer return type (see test case added), which would cause the assertion to fail. In fact, we have seen this assertion fail in real files. This fix prevents this failure. A desirable future feature would be to actually analyse non-pointer return types too. PiperOrigin-RevId: 504809450
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl