commit c1f628c448872d27be2a98e62b4abe506e9cc62a
author Martin Brænne <mboehme@google.com> Tue Feb 20 23:52:57 2024 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Feb 20 23:54:28 2024 -0800
tree 371c6d98500fc2241218b48f245db74e1ecc0951
parent ae0f4e1ab4e7aeea27d040a5ffbaa6269536def1

[nullability] A call to a non-const operator should also be considered mutating.

The additional test in this patch fails without the fix.

PiperOrigin-RevId: 608879021
Change-Id: I295a03fefbf4c5041e693daa211f524138e33479

nullability/pointer_nullability_matchers.cc

diff --git a/nullability/pointer_nullability_matchers.cc b/nullability/pointer_nullability_matchers.cc
index 47d26ce..854b68e 100644
--- a/nullability/pointer_nullability_matchers.cc
+++ b/nullability/pointer_nullability_matchers.cc
@@ -113,6 +113,10 @@
   return cxxMemberCallExpr(callee(cxxMethodDecl(unless(isConst()))));
 }
 
+Matcher<Stmt> isNonConstMemberOperatorCall() {
+  return cxxOperatorCallExpr(callee(cxxMethodDecl(unless(isConst()))));
+}
+
 Matcher<Stmt> isSmartPointerGlValue() {
   return expr(hasType(isSupportedSmartPointer()), isGLValue());
 }