commit c72a9d86d8f13601343a41688ea3954c77fa2161
author Lukasz Anforowicz <lukasza@google.com> Thu Sep 22 16:25:32 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Sep 22 16:26:11 2022 -0700
tree 504c64c3769ee94995bb98e63c77c6901c824c95
parent f8cfa56c7491b2b72d02f3f35d48354c374a45d1

Drop `for_current_target_` from `Importer::class_template_instantiations_`.

The renamed field includes decls from *all* targets, because
`IsFromCurrentTarget` *always* returns true for
`ClassTemplateSpecializationDecl`s, since `GetOwningTarget` has the
following code:

```
BazelLabel Importer::GetOwningTarget(const clang::Decl* decl) const {
  // Template instantiations need to be generated in the target that
  // triggered the instantiation (not in the target where the template
  // is defined).
  if (IsFullClassTemplateSpecializationOrChild(decl)) {
    return invocation_.target_;
  }
```

PiperOrigin-RevId: 476224525

rs_bindings_from_cc/importer.cc

diff --git a/rs_bindings_from_cc/importer.cc b/rs_bindings_from_cc/importer.cc
index aa1ab56..f609c9c 100644
--- a/rs_bindings_from_cc/importer.cc
+++ b/rs_bindings_from_cc/importer.cc
@@ -411,8 +411,8 @@
 std::vector<ItemId> Importer::GetOrderedItemIdsOfTemplateInstantiations()
     const {
   std::vector<SourceLocationComparator::OrderedItemId> items;
-  items.reserve(class_template_instantiations_for_current_target_.size());
-  for (const auto* decl : class_template_instantiations_for_current_target_) {
+  items.reserve(class_template_instantiations_.size());
+  for (const auto* decl : class_template_instantiations_) {
     items.push_back({GetSourceOrderKey(decl), GenerateItemId(decl)});
   }
 
@@ -664,7 +664,7 @@
 
   // Store `specialization_decl`s so that they will get included in
   // IR::top_level_item_ids.
-  class_template_instantiations_for_current_target_.insert(specialization_decl);
+  class_template_instantiations_.insert(specialization_decl);
 
   return ConvertTypeDecl(specialization_decl);
 }