tree c6f16907f61d16523485cc1d278772b3f0a2feba
parent 89959d5cf81d21edd78e89d6555d255f1ddc80fc
author Sam McCall <sammccall@google.com> 1687980156 -0700
committer Copybara-Service <copybara-worker@google.com> 1687980196 -0700

Simplify tests, drop analyze_target_for_test

analyze_target_for_test forces the AST-consuming code into a callback, and doesn't simplify much.

infer_nullability_constraints_test: use clang::TestAST and findValueDecl directly
Also fix use-after-free: pointers returned by inferAnnotationsForTargetFunction dangled.
while here, Target => target.

safety_constraint_generator_test: use dataflow::test::checkDataflow.
Avoid difficult-to-debug matchers-containing-callbacks by expressing the constraints as strings, assigning names to the variables we care about.
While here, Target => target.

safety_constraint_generator: pass Lattice/Env separately instead of in a pair type, to avoid ugly conversions (and copies!) between different pair types in tests
PiperOrigin-RevId: 544127985