| commit | d1e7cdf94775561dbc01360555acf6b48b24a4c9 | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@google.com> | Fri Sep 02 11:09:33 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Sep 02 11:10:06 2022 -0700 |
| tree | 44be52d380d893bf022de2014b4f1cf65811f18b | |
| parent | 0b3b70c101892b289f66a3e40d828f5b798b0f69 [diff] |
Refactoring: Extract GetCanonicalChildren.
This CL deduplicates children-traversal code that is needed by both
`Importer::GetItemIdsInSourceOrder` and by
`Importer::ImportDeclsFromDeclContext`. This CL extracts this code into
a new `GetCanonicalChildren` helper function.
This CL should only have minimal, inconsequential impact on code
behavior:
1. The same children decls should be traversed before and after this CL.
2. The traversal order may be different (for children of
`LinkageSpecDecl`). This order should be mostly inconsequential
because:
* `ImportDeclsFromDeclContext` mostly cares about populating
(unordered) `import_cache_`
* `GetItemIdsInSourceOrder` explicitly/separately sorts
the item ids it returns.
PiperOrigin-RevId: 471842517
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl