| commit | d803096b8669d0e84ae9ec7f745027cb853daccf | [log] [tgz] |
|---|---|---|
| author | Devin Jeanpierre <jeanpierreda@google.com> | Mon Jan 29 23:06:39 2024 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Jan 29 23:08:55 2024 -0800 |
| tree | 16639d7fb96059608a144a090f621f6e3b3265f9 | |
| parent | 06b0d5bfc8b58e65806e19f0f21458173c51b559 [diff] |
Do not generate bindings for forward declarations of enums.
The output _before_ this CL is just incorrect -- it treats `enum X : int;` as equivalent to `enum X : int {};`. That is wrong, in that you can forward declare an enum that is defined in another target. We would be better off producing nothing for now.
The correct approach requires design work. Unlike other forward declared types, forward declared enums are complete types, and have a known size. This should be workable, or at least possible to make work, with `forward_declare.rs`, but at the moment we haven't done so.
PiperOrigin-RevId: 602615570
Change-Id: Icccadf42c3178bab2c8797694473af7c6936b51c
Crubit is a bidirectional bindings generator for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
Crubit allows for C++ code and Rust code to call each other without manually wrapping the APIs in an FFI-friendly interop layer. For example, a C++ function like this:
bool IsAbsPath(std::string_view path);
... becomes callable from Rust as if it were defined as:
pub fn IsAbsPath(path: std::string_view) -> bool {...}
Crubit automatically generates ABI-compatible bindings for structs (which can be passed both by value and by reference), functions, and methods, for a large variety of types. (Trivial types, nontrivial types, templated types, etc.)
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl