| commit | edd7d33c450d20d73c19b2cbfca0278d032c6409 | [log] [tgz] |
|---|---|---|
| author | Sam McCall <sammccall@google.com> | Mon Apr 17 04:47:58 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Apr 17 04:48:30 2023 -0700 |
| tree | 90832d45763ae218b77ffa12b8f2340686267922 | |
| parent | 927e758544a46203b299ab687b88307c203f6159 [diff] |
Handle aliases (and all sugar) in type => nullability vector computation When walking a type looking for nullability slots, we assume an unhandled type node has no slots. We weren't handling type aliases, so we'd compute an empty nullability vector for `T` in `using T = int*;`, oops. Instead of just handling aliases specifically, add fallback handling for all sugar types to walk the underlying type. We can remove the uninteresting specific handling for certain sugar types. The special behavior for AttributedType still works, of course! Also added unittest covering getNullabilityAnnotationsFromType, which is the simplest way to test this change. This doesn't *nearly* cover all interesting cases, but will at least make it easier to add more later/migrate some away from __assert_nullability/test subsequent changes to nullability vector computation. This bug was the root cause of a problem identified with https://github.com/google/crubit/commit/7a808ea25d183f5f788c0fb3342ffec99d16c829 When handling a cast from nullopt to a pointer type, that change assumes the nullability vector of the result type is nonempty (it's a pointer type!) and assigns to the front of it. But when aliases were involved we got an incorrect empty vector. PiperOrigin-RevId: 524813522
Crubit is an experimental bidirectional bindings generator for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
Crubit allows for C++ code and Rust code to call each other without manually wrapping the APIs in an FFI-friendly interop layer. For example, a C++ function like this:
bool IsAbsPath(std::string_view path);
... becomes callable from Rust as if it were defined as:
pub fn IsAbsPath(path: std::string_view) -> bool {...}
Crubit automatically generates ABI-compatible bindings for structs (which can be passed both by value and by reference), functions, and methods, for a large variety of types. (Trivial types, nontrivial types, templated types, etc.)
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl