| commit | fc6812100ccaf8f47b8b3414755d7ad86c3a8880 | [log] [tgz] |
|---|---|---|
| author | Devin Jeanpierre <jeanpierreda@google.com> | Fri Dec 30 11:21:14 2022 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Dec 30 11:21:47 2022 -0800 |
| tree | 81873111e240c5568118f197cc8bf531f6c8a921 | |
| parent | 0182c5c085e2c179c73695a996902a5f8b7ed537 [diff] |
Remove variant checks when they precede a `std::get<>(Variant)` call.
If the wrong variant is active, `std::get<>` will throw an exception, and terminate the process because exceptions are disabled. If we don't want to rely on exceptions terminating the process, then IMO we should use a function that is like std::get but crashes, as so:
```cc
template <size_t i, typename T>
auto GetOrDie(T&& variant) noexcept -> decltype(std::get<i>(variant)) {
return std::get<i>(std::forward(variant));
}
```
The `assert(!IsError())` calls don't have as much information about what went wrong as the exception might, and are easy to forget. When it's an `assert`, it only ever does things in debug mode anyway.
PiperOrigin-RevId: 498611220
Extremely experimental interop tooling for C++ and Rust.
Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.
$ apt install clang lld bazel $ git clone git@github.com:google/crubit.git $ cd crubit $ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl
$ git clone https://github.com/llvm/llvm-project $ cd llvm-project $ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install $ cmake --build build -j $ # wait... $ cmake --install build $ cd ../crubit $ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl