| commit | d87d2b43046778da7b09d032f49a0028f3b4d321 | [log] [tgz] |
|---|---|---|
| author | Copybara-Service <copybara-worker@google.com> | Thu Feb 04 05:22:40 2021 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 04 05:22:40 2021 -0800 |
| tree | 67669c6788746979e49207896ced2ce86b95214f | |
| parent | e97ea7e0141da040c34748a75f98276e29014b33 [diff] | |
| parent | a2467ce725df27450ecf8bf676f7c55e4edd413d [diff] |
Merge pull request #24 from shanjiantao:master PiperOrigin-RevId: 355604706 Change-Id: I70bf26c119dcac2d2ab4807cee4132e0625ecf59
This repository houses all canonical constraint_setting()s, constraint_value()s and platform()s that are universally useful across languages and Bazel projects.
For questions or concerns please email bazel-discuss@googlegroups.com.
Constraints must be carefully organized to avoid fragmentation. If two different declarations for, say, cpu=x86_64 were to exist at the same time then select() statements and toolchain selection would stop working across languages and projects.
This repository only includes truly ubiquitous constraints.
Most common constraints -- that is settings and values that can be used across projects - fall into specific areas like “Apple” or “Java”. These are declared in those areas' respective repositories.
A very few constraints (such as OS and cpu) are relevant for essentially all projects across all areas. These are what this repository is for.
To add a new canonical constraint value, prepare a PR adding it to that the appropriate BUILD file.
Note that even global constraint values are typically area values. For example, ios is an area value for the global setting os but belongs in the apple area. For the PR's reviewer(s) choose an owner of this repository plus an owner of the area repository this references..
A constraint value should be:
semantically clear, particularly in its distinctions from other values of the same setting
well-named: consistent with existing values of the same setting and easy to understand at usage sites
well-documented
Remember that this value will apply for the entire Bazel community and its semantics will be difficult to impossible to change once it starts being used.
New canonical constraint settings should be rare and well-justified.
To add a new setting, prepare a design document according to Bazel's design review process. This document should explain the need for a new setting and why it belongs here vs. area-specific repositories. It should clearly explain semantics, initial values, and criteria for adding new values.
Once the design is approved prepare a PR for the actual change. If any values are area-specific, include the area repositories' owners as reviewers.
If you‘d like to experiment with changes to global settings or values, you can fork this repo for experimental purposes. But in the interest of community health and interoperability please don’t share your changes with anyone not involved with the experiment. For wider distribution, submit a proper change here.
Note that you can declare constraint_values in your own repo that are members of the global constraint_settings. This lets you “extend” global settings within the confines of your own project. But don't do this if you expect other projects to use these changes - this can easily lead to fragmentation conflicts.
If you need custom constaint_settings, just declare them in your own repo. They are, by definition, not global.
If you really need a permanent global change and it isn't design-approved for this repo, contact bazel-dev@googlegroups.com to discuss options.