commit 5fe8347f73056e7649af2116c2f40a93bb088c83
author Googler <cushon@google.com> Tue Oct 15 07:39:41 2024 -0700
committer rules_java Copybara <noreply@google.com> Tue Oct 15 07:40:14 2024 -0700
tree 39f365e46750040f22c918a91d3fd1a5087ca3cd
parent 9226c76e4f2f5e802f65423c86fde8d9244844a6

Add `-XDshould-stop.ifError=FLOW` to the default javacopts.

See https://github.com/google/error-prone/issues/4595 for motivation. This fixes a bug with the interaction between javac and Error Prone, but also improves diagnostic quality in general by showing more errors if there are multiple problems and multiple files being compiled.

PiperOrigin-RevId: 686100365
Change-Id: I2e5e6dffdbbe1ca6480369a51a7ea3445db78a8a

toolchains/default_java_toolchain.bzl

diff --git a/toolchains/default_java_toolchain.bzl b/toolchains/default_java_toolchain.bzl
index 0c81bdb..9efc2f3 100644
--- a/toolchains/default_java_toolchain.bzl
+++ b/toolchains/default_java_toolchain.bzl
@@ -56,6 +56,7 @@
 DEFAULT_JAVACOPTS = [
     "-XDskipDuplicateBridges=true",
     "-XDcompilePolicy=simple",
+    "-XDshould-stop.ifError=FLOW",  # See b/27049950, https://github.com/google/error-prone/issues/4595
     "-g",
     "-parameters",
     # https://github.com/bazelbuild/bazel/issues/15219