tree e31667df676c1dd6d509d62352e06ab03b8c14fe
parent b39810e07ea3f484c63a3d6ca8ba9b2fc6c08530
author David Ostrovsky <david@ostrovsky.org> 1787302019 -0700
committer rules_java Copybara <noreply@google.com> 1787302040 -0700

Add a `java_toolchain` attribute to specify options to the `header_compiler_direct` tool (#375)

Primary motivation is to let users not using the Turbine graal native image silence protobuf sun.misc.Unsafe warnings from the direct header compiler

turbine_direct (header_compiler_direct) bundles protobuf, whose UnsafeUtil calls terminally-deprecated sun.misc.Unsafe methods. On JDK 24+ (JEP 498) the JVM prints a warning for each such call during header compilation:

  WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
  WARNING: sun.misc.Unsafe::arrayBaseOffset has been called by
  com.google.protobuf.UnsafeUtil (.../java_tools/turbine_direct_binary_deploy.jar)

Unlike the Turbine worker, header_compiler_direct does not receive turbine_jvm_opts, and --jvmopt does not reach header-compilation actions, so a toolchain currently has no way to silence these warnings for the direct header compiler. Add --sun-misc-unsafe-memory-access=allow to header_compiler_direct_jvm_opts, gated on the runtime feature version since the flag is rejected on JDK <= 22.

See https://github.com/protocolbuffers/protobuf/issues/20760.

Fixes #374

Closes #375

COPYBARA_INTEGRATE_REVIEW=https://github.com/bazelbuild/rules_java/pull/375 from davido:turbine-direct-unsafe-memory-access da635b6bebb7ac660f19451469182f54adea884c
PiperOrigin-RevId: 968352943
Change-Id: I94d5bc5d564016ced3cc3b6e06330fad4d8451a7