commit 1f3524ace419234e1be3a78cfa8da35e82b5c330
author ivanhernandez <ivanhernandez@google.com> Thu Aug 08 17:53:12 2019 +0000
committer Ivan Hernandez <ivanhernandez@google.com> Wed Aug 14 19:00:25 2019 +0000
tree f9e110574ef78d4dfb62fd5488a621905f8bfe75
parent 515e77538988cf52392357336df7fd81a0c1385e

Change XCTFail in setUp() to print statements because calling XCTFail results in a test crash and prevents the errors from being displayed. If something fails in setUp(), the errors will be printed and the test will eventually fail do to setup not being done.

Also bumps the simulator version to iOS 12.2.

PiperOrigin-RevId: 262388845

src/TulsiEndToEndTests/TulsiEndToEndTest.swift

diff --git a/src/TulsiEndToEndTests/TulsiEndToEndTest.swift b/src/TulsiEndToEndTests/TulsiEndToEndTest.swift
index 2efa943..cf86f9a 100644
--- a/src/TulsiEndToEndTests/TulsiEndToEndTest.swift
+++ b/src/TulsiEndToEndTests/TulsiEndToEndTest.swift
@@ -22,11 +22,17 @@
 // generated xcodeproj by running the projects unit tests.
 class TulsiEndToEndTest: BazelIntegrationTestCase {
   fileprivate static let simulatorName = "tulsie2e-\(UUID().uuidString.prefix(8))"
-  fileprivate static let targetVersion = "12.1"
+  fileprivate static let targetVersion = "12.2"
 
   let fileManager = FileManager.default
   var runfilesWorkspaceURL: URL! = nil
 
+  // Calling XCTFail() in a setUp() function will cause the test to crash and hide any logs.
+  // Instead, explicitly log that a set up error occured.
+  static func setUpFailure(_ msg: String) {
+    print("SETUP FAILURE: \(msg)")
+  }
+
   // Creates a new simulator, for use with testing generated projects, before any tests run.
   override class func setUp() {
     super.setUp()
@@ -45,15 +51,15 @@
 
     if completionInfo.terminationStatus != 0 {
       if let stderr = String(data: completionInfo.stderr, encoding: .utf8), !stderr.isEmpty {
-        XCTFail("\(completionInfo.commandlineString) failed with error: \(stderr)")
+        TulsiEndToEndTest.setUpFailure("\(completionInfo.commandlineString) failed with error: \(stderr)")
       } else {
-        XCTFail("\(completionInfo.commandlineString) encountered an error. Exit code \(completionInfo.terminationStatus).")
+        TulsiEndToEndTest.setUpFailure("\(completionInfo.commandlineString) encountered an error. Exit code \(completionInfo.terminationStatus).")
       }
     }
 
     // 'simctl' should output the UUID of the new simulator if it was created successfully.
     if let stdout = String(data: completionInfo.stdout, encoding: .utf8), stdout.isEmpty {
-      XCTFail("No UUID was ouputted for newly created simulator.")
+      TulsiEndToEndTest.setUpFailure("No UUID was ouputted for newly created simulator.")
     }
   }
 
@@ -94,7 +100,7 @@
                                                                        workspaceRootURL.path])
 
       if let error = String(data: completionInfo.stderr, encoding: .utf8), !error.isEmpty {
-        XCTFail(error)
+        TulsiEndToEndTest.setUpFailure(error)
       }
     }