)]}' { "commit": "270eae09f5577517b817fa35ca2b89b7e0d89475", "tree": "53558bebd2b139c11587e279b02d021b282d9838", "parents": [ "dad7c85aa96707cf5903907b84a5c8358b516a73" ], "author": { "name": "Kyle Teske", "email": "kjteske@gmail.com", "time": "Thu Jun 11 09:25:47 2020 -0400" }, "committer": { "name": "Kyle Teske", "email": "kjteske@gmail.com", "time": "Thu Jun 11 11:52:08 2020 -0400" }, "message": "Fix Xcode 11.3.1 detection in an Xcode workspace\n\nWhen using a Tulsi-generated project by itself in Xcode 11.3.1, Xcode\nsets XCODE_VERSION_ACTUAL to 1131, which Tulsi parses correctly to get\nthe version 11.3.1.\n\nBut when used in an Xcode workspace, Xcode sets XCODE_VERSION_ACTUAL\nto 1130, leading to Tulsi parsing 11.3 as the version, and later\nattempts to use a non-existing version of Xcode to build, which results\nin an error.\n\nFix by ignoring XCODE_VERSION_ACTUAL because it\u0027s unreliable; instead,\nparse Xcode\u0027s version.plist to read the \u0027CFBundleShortVersionString\u0027\nentry, which seems to return correct results.\n\nCaveat: this implementation uses plistlib, which has a slightly\ndifferent API in python2 and python3. This change uses the python2 API,\nand will need to be updated to work with python3 in the future.\nPiperOrigin-RevId: 315886285\n", "tree_diff": [ { "type": "modify", "old_id": "f741b508a982c997e9cd2785c856edfe094c3c07", "old_mode": 33261, "old_path": "src/TulsiGenerator/Scripts/bazel_build.py", "new_id": "0723f7ece63b6f43348a7731427c3c4cb4116e32", "new_mode": 33261, "new_path": "src/TulsiGenerator/Scripts/bazel_build.py" } ] }