| commit | 01183bcaae4a77b6c7577aedda02cd5aa4ef0755 | [log] [tgz] |
|---|---|---|
| author | arostovtsev <arostovtsev@google.com> | Fri Apr 15 12:40:55 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Apr 15 12:42:10 2022 -0700 |
| tree | e4a373096211dbc535b279dd818d06f472275645 | |
| parent | 92d760b37722feffd5b1121e4f9a1152d8120946 [diff] |
Fix crash with --allow_analysis_failures when RuleClass.ConfiguredTargetFactory.create() returns null Native implementations of RuleClass.ConfiguredTargetFactory.create() can return null, either explicitly (e.g. see GenRuleBase.java) or by calling RuleConfiguredTargetBuilder.build() - which is @Nullable. This fact was neither documented nor annotated. The natural result was that ConfiguredTargetFactory misused the API and assumed the returned ConfiguredTarget was non-null. In fact, it can be null, and requires wrapping in an erroredConfiguredTarget() - same as for Starlark rule classes. Fixes e.g. crashes with --allow_analysis_failures (or when using Skylib's analysistest with expect_falure = True) in genrules with failing make variable expansion, but the same class of crash could until now have been triggered using many other native rules. All such rules' create() methods are now annotated @Nullable for clarity. PiperOrigin-RevId: 442074108
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
