Switch back the default for --incompatible_package_name_is_a_function
The value was changed in https://github.com/bazelbuild/bazel/commit/4a8bacd33d96b0499bb4d8303d285133268c01b4, but it is breaking downstream projects
#5827
RELNOTES: Revert the default of --incompatible_package_name_is_a_function to false.
PiperOrigin-RevId: 212297376
diff --git a/site/docs/skylark/backward-compatibility.md b/site/docs/skylark/backward-compatibility.md
index 2dc81f5..6b31bd4 100644
--- a/site/docs/skylark/backward-compatibility.md
+++ b/site/docs/skylark/backward-compatibility.md
@@ -180,7 +180,7 @@
same flag.
* Flag: `--incompatible_package_name_is_a_function`
-* Default: `true`
+* Default: `false`
### FileType is deprecated
diff --git a/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java
index d38a808..cb74303 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/SkylarkSemanticsOptions.java
@@ -316,7 +316,7 @@
@Option(
name = "incompatible_package_name_is_a_function",
- defaultValue = "true",
+ defaultValue = "false",
documentationCategory = OptionDocumentationCategory.SKYLARK_SEMANTICS,
effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
metadataTags = {
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
index 0b5aef5..2062ae1 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
@@ -127,7 +127,7 @@
.incompatibleGenerateJavaCommonSourceJar(false)
.incompatibleNewActionsApi(false)
.incompatibleNoSupportToolsInActionInputs(false)
- .incompatiblePackageNameIsAFunction(true)
+ .incompatiblePackageNameIsAFunction(false)
.incompatibleRangeType(false)
.incompatibleRemoveNativeGitRepository(false)
.incompatibleRemoveNativeHttpArchive(false)
