| commit | 035d56cb7c05575c44a2d8917d53d87a8ddd68de | [log] [tgz] |
|---|---|---|
| author | michajlo <michajlo@google.com> | Wed Jun 05 12:58:31 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jun 05 12:59:25 2019 -0700 |
| tree | 0be6869294dd270ce9b37dae4ba87bddc9c3a8e1 | |
| parent | d286084a4200303dc192c81bc979c9da5b5b6829 [diff] |
Remove StartupOptions from globals Demote from global-always-mutable state to sometimes-mutable state that's passed around, making it clear what depends on it. We should be able to mark StartupOptions const in many of the places we use it, but the GetArgumentArray calls peppered throughout the code rely on non-const GetServerJavabase. I'll figure out how to deal with that in another pass, either by making GetServerJavabase const, lifting its use to a place that doesn't matter, only computing args once, or some combination of such. I stuck to passing a StartupOptions* in the code to keep the mass "globals->options->" to "startup_options->" migration less interesting. By reference would probably be better, but I think maybe for another go... As usual, a downside to this is growing argument lists, but I think that's better than guessing or having no enforcement of when a method might update globals->options. PiperOrigin-RevId: 251700379
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.