| commit | 05d4c96cadb424ce3af73484fba5547a542e6d8a | [log] [tgz] |
|---|---|---|
| author | Googler <gnish@google.com> | Thu Dec 14 02:20:30 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Dec 14 02:22:08 2023 -0800 |
| tree | 43df12a1e93545e66ba58b42135cc91df299f778 | |
| parent | 3c298fdb868d17d30ef5c19b3f3b488e5ed2c8a9 [diff] |
Starlarkify `getBuildVariables`. Unfortunately there is no good way of Starlarkifying this method without moving some of the techdebt from Java to Starlark. There are two root causes for this problem: * [getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas](https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/rules/cpp/CcToolchainProvider.java;l=724-739;drc=b074ddb86eb0cdb7ca96110d6c3c8b602dde08d8) I believe this can be deleted once [incompatible_disable_starlark_host_transitions](https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java;l=622-631;drc=106aec622f0cd011467bdc63b50982afc961e2d5) is set to `True` and removed. * Right now because we have different build variables for apple and non-apple platforms we have to live with this ugly callback closure [functions](https://cs.opensource.google/bazel/bazel/+/master:src/main/starlark/builtins_bzl/common/cc/cc_toolchain_provider_helper.bzl;l=234-237;drc=14c8411279f8b462c2c100b64454f7b68880b14d) which calculate them. Either we have to remove this difference or remove support of build variables altogether in the future. Also since there is Starlark as well as Java code referring to `getBuildVariables` this cl could have been simplified if we had left Java implementation in place so that Java code calls into Java implementation and Starlark calls into Starlark one. However this I believe introduces more pain and confusion for the future so I've decided to go against this decision. PiperOrigin-RevId: 590866747 Change-Id: Ibff225ddf37684ece54c4df2171e79f20377cb6a
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
