Fix classes that create OptionsParser instances to directly use the Builder.
PiperOrigin-RevId: 253800892
diff --git a/src/test/java/com/google/devtools/build/lib/exec/BlazeExecutorTest.java b/src/test/java/com/google/devtools/build/lib/exec/BlazeExecutorTest.java
index 41c7a94..ca604ed 100644
--- a/src/test/java/com/google/devtools/build/lib/exec/BlazeExecutorTest.java
+++ b/src/test/java/com/google/devtools/build/lib/exec/BlazeExecutorTest.java
@@ -63,7 +63,8 @@
@Test
public void testDebugPrintActionContexts() throws Exception {
TestExecutorBuilder builder = new TestExecutorBuilder(fileSystem, directories, binTools);
- OptionsParser parser = OptionsParser.newOptionsParser(TestExecutorBuilder.DEFAULT_OPTIONS);
+ OptionsParser parser =
+ OptionsParser.builder().optionsClasses(TestExecutorBuilder.DEFAULT_OPTIONS).build();
parser.parse("--debug_print_action_contexts");
Reporter reporter = new Reporter(new EventBus());
diff --git a/src/test/java/com/google/devtools/build/lib/exec/util/TestExecutorBuilder.java b/src/test/java/com/google/devtools/build/lib/exec/util/TestExecutorBuilder.java
index beaefce..57dbf12 100644
--- a/src/test/java/com/google/devtools/build/lib/exec/util/TestExecutorBuilder.java
+++ b/src/test/java/com/google/devtools/build/lib/exec/util/TestExecutorBuilder.java
@@ -50,7 +50,8 @@
private final FileSystem fileSystem;
private final BlazeDirectories directories;
private Reporter reporter = new Reporter(new EventBus());
- private OptionsParser optionsParser = OptionsParser.newOptionsParser(DEFAULT_OPTIONS);
+ private OptionsParser optionsParser =
+ OptionsParser.builder().optionsClasses(DEFAULT_OPTIONS).build();
private List<ActionContext> strategies = new ArrayList<>();
private final Map<String, List<SpawnActionContext>> spawnStrategyMap =
new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
diff --git a/src/test/java/com/google/devtools/build/lib/runtime/commands/CleanCommandRecommendsAsyncTest.java b/src/test/java/com/google/devtools/build/lib/runtime/commands/CleanCommandRecommendsAsyncTest.java
index 1073726..1dbccad 100644
--- a/src/test/java/com/google/devtools/build/lib/runtime/commands/CleanCommandRecommendsAsyncTest.java
+++ b/src/test/java/com/google/devtools/build/lib/runtime/commands/CleanCommandRecommendsAsyncTest.java
@@ -90,7 +90,7 @@
.setProductName(productName)
.setServerDirectories(serverDirectories)
.setStartupOptionsProvider(
- OptionsParser.newOptionsParser(BlazeServerStartupOptions.class))
+ OptionsParser.builder().optionsClasses(BlazeServerStartupOptions.class).build())
.addBlazeModule(
new BlazeModule() {
@Override
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java b/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java
index 63054cb..a8c4f8d 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java
@@ -144,7 +144,10 @@
@Before
public final void initialize() throws Exception {
- options = OptionsParser.newOptionsParser(KeepGoingOption.class, BuildRequestOptions.class);
+ options =
+ OptionsParser.builder()
+ .optionsClasses(KeepGoingOption.class, BuildRequestOptions.class)
+ .build();
options.parse();
inMemoryCache = new InMemoryActionCache();
tsgm = new TimestampGranularityMonitor(clock);
diff --git a/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java b/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java
index aba06f6..b74fca8 100644
--- a/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java
+++ b/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java
@@ -114,7 +114,8 @@
"mock-product-name");
// This call implicitly symlinks the integration bin tools into the exec root.
IntegrationMock.get().getIntegrationBinTools(fileSystem, directories);
- OptionsParser optionsParser = OptionsParser.newOptionsParser(ExecutionOptions.class);
+ OptionsParser optionsParser =
+ OptionsParser.builder().optionsClasses(ExecutionOptions.class).build();
optionsParser.parse("--verbose_failures");
LocalExecutionOptions localExecutionOptions = Options.getDefaults(LocalExecutionOptions.class);
diff --git a/src/test/java/com/google/devtools/build/lib/testutil/TestMode.java b/src/test/java/com/google/devtools/build/lib/testutil/TestMode.java
index cca7363..0404474 100644
--- a/src/test/java/com/google/devtools/build/lib/testutil/TestMode.java
+++ b/src/test/java/com/google/devtools/build/lib/testutil/TestMode.java
@@ -31,7 +31,8 @@
public abstract class TestMode {
private static StarlarkSemantics parseSkylarkSemantics(String... skylarkOptions)
throws Exception {
- OptionsParser parser = OptionsParser.newOptionsParser(StarlarkSemanticsOptions.class);
+ OptionsParser parser =
+ OptionsParser.builder().optionsClasses(StarlarkSemanticsOptions.class).build();
parser.parse(skylarkOptions);
return parser.getOptions(StarlarkSemanticsOptions.class).toSkylarkSemantics();
}
diff --git a/src/test/java/com/google/devtools/build/lib/util/OptionsUtilsTest.java b/src/test/java/com/google/devtools/build/lib/util/OptionsUtilsTest.java
index 24a2b25..54eccca 100644
--- a/src/test/java/com/google/devtools/build/lib/util/OptionsUtilsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/util/OptionsUtilsTest.java
@@ -77,7 +77,8 @@
@Test
public void asStringOfExplicitOptions() throws Exception {
- OptionsParser parser = OptionsParser.newOptionsParser(IntrospectionExample.class);
+ OptionsParser parser =
+ OptionsParser.builder().optionsClasses(IntrospectionExample.class).build();
parser.parse("--alpha=no", "--gamma=no", "--echo=no");
assertThat(OptionsUtils.asShellEscapedString(parser)).isEqualTo("--alpha=no --gamma=no");
assertThat(OptionsUtils.asArgumentList(parser))
@@ -87,7 +88,8 @@
@Test
public void asStringOfExplicitOptionsCorrectSortingByPriority() throws Exception {
- OptionsParser parser = OptionsParser.newOptionsParser(IntrospectionExample.class);
+ OptionsParser parser =
+ OptionsParser.builder().optionsClasses(IntrospectionExample.class).build();
parser.parse(PriorityCategory.COMMAND_LINE, null, Arrays.asList("--alpha=no"));
parser.parse(PriorityCategory.COMPUTED_DEFAULT, null, Arrays.asList("--beta=no"));
assertThat(OptionsUtils.asShellEscapedString(parser)).isEqualTo("--beta=no --alpha=no");
@@ -114,14 +116,14 @@
@Test
public void asStringOfExplicitOptionsWithBooleans() throws Exception {
- OptionsParser parser = OptionsParser.newOptionsParser(BooleanOpts.class);
+ OptionsParser parser = OptionsParser.builder().optionsClasses(BooleanOpts.class).build();
parser.parse(PriorityCategory.COMMAND_LINE, null, Arrays.asList("--b_one", "--nob_two"));
assertThat(OptionsUtils.asShellEscapedString(parser)).isEqualTo("--b_one --nob_two");
assertThat(OptionsUtils.asArgumentList(parser))
.containsExactly("--b_one", "--nob_two")
.inOrder();
- parser = OptionsParser.newOptionsParser(BooleanOpts.class);
+ parser = OptionsParser.builder().optionsClasses(BooleanOpts.class).build();
parser.parse(PriorityCategory.COMMAND_LINE, null, Arrays.asList("--b_one=true", "--b_two=0"));
assertThat(parser.getOptions(BooleanOpts.class).bOne).isTrue();
assertThat(parser.getOptions(BooleanOpts.class).bTwo).isFalse();
@@ -133,7 +135,8 @@
@Test
public void asStringOfExplicitOptionsMultipleOptionsAreMultipleTimes() throws Exception {
- OptionsParser parser = OptionsParser.newOptionsParser(IntrospectionExample.class);
+ OptionsParser parser =
+ OptionsParser.builder().optionsClasses(IntrospectionExample.class).build();
parser.parse(PriorityCategory.COMMAND_LINE, null, Arrays.asList("--alpha=one"));
parser.parse(PriorityCategory.COMMAND_LINE, null, Arrays.asList("--alpha=two"));
assertThat(OptionsUtils.asShellEscapedString(parser)).isEqualTo("--alpha=one --alpha=two");
diff --git a/src/test/java/com/google/devtools/build/lib/worker/ExampleWorker.java b/src/test/java/com/google/devtools/build/lib/worker/ExampleWorker.java
index 68ac879..15ce123 100644
--- a/src/test/java/com/google/devtools/build/lib/worker/ExampleWorker.java
+++ b/src/test/java/com/google/devtools/build/lib/worker/ExampleWorker.java
@@ -59,7 +59,11 @@
public static void main(String[] args) throws Exception {
if (ImmutableSet.copyOf(args).contains("--persistent_worker")) {
- OptionsParser parser = OptionsParser.newOptionsParser(false, ExampleWorkerOptions.class);
+ OptionsParser parser =
+ OptionsParser.builder()
+ .optionsClasses(ExampleWorkerOptions.class)
+ .allowResidue(false)
+ .build();
parser.parse(args);
ExampleWorkerOptions workerOptions = parser.getOptions(ExampleWorkerOptions.class);
Preconditions.checkState(workerOptions.persistentWorker);
@@ -155,7 +159,8 @@
}
}
- OptionsParser parser = OptionsParser.newOptionsParser(true, ExampleWorkOptions.class);
+ OptionsParser parser =
+ OptionsParser.builder().optionsClasses(ExampleWorkOptions.class).allowResidue(true).build();
parser.parse(expandedArgs.build());
ExampleWorkOptions options = parser.getOptions(ExampleWorkOptions.class);
